Re: [PATCH v4 2/3] fs: Convert kiocb rw_hint from enum to u16
From: Christoph Hellwig <hch@infradead.org>
Date: 2018-05-18 16:05:15
Also in:
linux-api, linux-fsdevel, lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2018-05-18 16:05:15
Also in:
linux-api, linux-fsdevel, lkml
+/* ki_hint changed from enum to u16, make sure rw_hint fits into u16 */
I don't think this comment is very useful.
+static inline u16 ki_hint_valid(enum rw_hint hint)
I'd call this ki_hint_validate.
+{
+ if (hint > MAX_KI_HINT)
+ return 0;
+
+ return hint;Nit: kill the empty line.