Re: [PATCH 01/11] fs: add O_BENEATH_ONLY flag to openat(2)
From: Andy Lutomirski <luto@amacapital.net>
Date: 2014-06-30 15:53:26
Also in:
lkml
From: Andy Lutomirski <luto@amacapital.net>
Date: 2014-06-30 15:53:26
Also in:
lkml
On Mon, Jun 30, 2014 at 8:49 AM, David Drysdale [off-list ref] wrote:
On Mon, Jun 30, 2014 at 07:49:41AM -0700, Andy Lutomirski wrote:quoted
On Jun 30, 2014 3:36 AM, "David Drysdale" [off-list ref] wrote:quoted
Add a new O_BENEATH_ONLY flag for openat(2) which restricts the provided path, rejecting (with -EACCES) paths that are not beneath the provided dfd. In particular, reject: - paths that contain .. components - paths that begin with / - symlinks that have paths as above.I like this a lot. However, I think I'd like it even better if it were AT_BENEATH_ONLY so that it could be added to the rest of the *at family. --AndyWouldn't it need to be both O_BENEATH_ONLY (for openat()) and AT_BENEATH_ONLY (for other *at() functions), like O_NOFOLLOW and AT_SYMLINK_NOFOLLOW? (I.e. aren't the AT_* flags in a different numbering space than O_* flags?) Or am I misunderstanding?
Ugh, you're probably right. I wish openat had separate flags and atflags arguments. Oh well. --Andy -- Andy Lutomirski AMA Capital Management, LLC