Re: [PATCH 2/4] Convert epoll to a bitlock

From
Jonathan Corbet <hidden>
Date
2009-02-04 13:36:24
Also in
lkml
Reply to
Nick Piggin, 2009-02-04
On Wed, 4 Feb 2009 18:20:18 +1100
Nick Piggin [off-list ref] wrote:
On Wednesday 04 February 2009 18:13:20 Christoph Hellwig wrote:
quoted
On Tue, Feb 03, 2009 at 04:19:31PM -0700, Jonathan Corbet wrote:  
quoted
 1) Use i_lock to protect accesses to f_flags.  This would enable
some BKL usage to be removed, but would not fix fasync.  
What about just turning f_ep_lock into f_lock and using it?  
Ah, yes I was going to say that too, but I confused i_lock with
i_mutex because it sounded like Jon needed a sleeping lock here?
Sigh, obviously that's what I should do.  Sorry for being so dense.
Consider it done.

[About sleeping locks: *if* one puts a lock around ->fasync(), it needs
to be a sleeping lock.  But moving FASYNC bit handling down gets rid of
the need to do that, so f_lock would be fine.]

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (24 messages) 24 messages, 8 authors, last reply 2009-02-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help