Re: [PATCH 2/4] Convert epoll to a bitlock

From
Christoph Hellwig <hidden>
Date
2009-02-04 07:14:25
Also in
lkml
Reply to
Jonathan Corbet, 2009-02-03
On Tue, Feb 03, 2009 at 04:19:31PM -0700, Jonathan Corbet wrote:
 1) Use i_lock to protect accesses to f_flags.  This would enable some 
    BKL usage to be removed, but would not fix fasync.
What about just turning f_ep_lock into f_lock and using it?
 2) Move responsibility for the FASYNC bit into ->fasync(), with
    fasync_helper() doing it in almost all situations.  The remaining
    BKL usage would then go away.

 3) The same optional fasync() return values cleanup.
These two sound like a good thing to do no matter what the final locking
looks like.  I think they should be moved to the front of the patch
series and queued up no matter what.

--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (24 messages) 24 messages, 8 authors, last reply 2009-02-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help