Re: [PATCH 2/4] Convert epoll to a bitlock

From
Nick Piggin <hidden>
Date
2009-02-04 04:55:09
Also in
lkml
Reply to
Andrew Morton, 2009-02-03
On Wednesday 04 February 2009 08:39:42 Andrew Morton wrote:
On Mon,  2 Feb 2009 11:20:09 -0700

Jonathan Corbet [off-list ref] wrote:
quoted
Matt Mackall suggested converting epoll's ep_lock to a bitlock as a way
of saving space in struct file.  This patch makes that change.
hrm.  bit_spin_lock() makes people upset (large penguiny people).  iirc
it doesn't have all the correct/well-understood memory/compiler
ordering semantics which spinlocks have.
Bit spinlocks are OK now they are using lock bitops. Of course, they are
even nicer (and become very comparable to spinlocks) if you can use the
non-atomic unlock __bit_spin_unlock().

But it seems probably like another approach being discussed is a better
idea anyway.
And lockdep doesn't know about
it.
This is a valid concern. Someone had a patch to add lockdep support to it,
which might be a good idea to do. But for small inner locks, maybe not a
huge problem.
Thread (24 messages) 24 messages, 8 authors, last reply 2009-02-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help