Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error

From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-16 06:33:37
Also in: linux-arm-kernel, linux-iommu, linux-mips, linux-s390, linuxppc-dev, lkml, sparclinux, xen-devel
Reply to: Logan Gunthorpe, 2021-07-15

On Thu, Jul 15, 2021 at 10:45:44AM -0600, Logan Gunthorpe wrote:

quoted hunk ↗ jump to hunk

@@ -194,6 +194,8 @@ static int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg,
 	else
 		ents = ops->map_sg(dev, sg, nents, dir, attrs);
 
+	WARN_ON_ONCE(ents == 0);

Turns this into a negative error code while we're at it, just to keep
the callers sane?

Logan Gunthorpe · 2021-07-15
[PATCH v1 02/16] dma-direct: Return appropriate error code from dma_direct_map_sg() · Logan Gunthorpe · 2021-07-15
[PATCH v1 03/16] iommu: Return full error code from iommu_map_sg[_atomic]() · Logan Gunthorpe · 2021-07-15
[PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error · Christoph Hellwig · 2021-07-16
Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error · Robin Murphy · 2021-07-16
Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error · Logan Gunthorpe · 2021-07-16
[PATCH v1 01/16] dma-mapping: Allow map_sg() ops to return negative error codes · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 01/16] dma-mapping: Allow map_sg() ops to return negative error codes · Christoph Hellwig · 2021-07-16
[PATCH v1 13/16] xen: swiotlb: return error code from xen_swiotlb_map_sg() · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 13/16] xen: swiotlb: return error code from xen_swiotlb_map_sg() · Boris Ostrovsky · 2021-07-19
[PATCH v1 10/16] s390/pci: return error code from s390_dma_map_sg() · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 10/16] s390/pci: return error code from s390_dma_map_sg() · Niklas Schnelle · 2021-07-16
[PATCH v1 14/16] x86/amd_gart: return error code from gart_map_sg() · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 14/16] x86/amd_gart: return error code from gart_map_sg() · Christoph Hellwig · 2021-07-16
Re: [PATCH v1 14/16] x86/amd_gart: return error code from gart_map_sg() · Robin Murphy · 2021-07-16
[PATCH v1 12/16] parisc: return error code from .map_sg() ops · Logan Gunthorpe · 2021-07-15
[PATCH v1 08/16] MIPS/jazzdma: return error code from jazz_dma_map_sg() · Logan Gunthorpe · 2021-07-15
[PATCH v1 09/16] powerpc/iommu: return error code from .map_sg() ops · Logan Gunthorpe · 2021-07-15
[PATCH v1 07/16] ia64/sba_iommu: return error code from sba_map_sg_attrs() · Logan Gunthorpe · 2021-07-15
[PATCH v1 06/16] ARM/dma-mapping: return error code from .map_sg() ops · Logan Gunthorpe · 2021-07-15
[PATCH v1 05/16] alpha: return error code from alpha_pci_map_sg() · Logan Gunthorpe · 2021-07-15
[PATCH v1 04/16] dma-iommu: Return error code from iommu_dma_map_sg() · Logan Gunthorpe · 2021-07-15
Re: [PATCH v1 04/16] dma-iommu: Return error code from iommu_dma_map_sg() · Christoph Hellwig · 2021-07-16
[PATCH v1 11/16] sparc/iommu: return error codes from .map_sg() ops · Logan Gunthorpe · 2021-07-15
[PATCH v1 15/16] dma-mapping: return error code from dma_dummy_map_sg() · Logan Gunthorpe · 2021-07-15
Russell King (Oracle) · 2021-07-15
Logan Gunthorpe · 2021-07-15
View all 28 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help