Re: [PATCH v1 14/16] x86/amd_gart: return error code from gart_map_sg()
- From
- Christoph Hellwig <hch@lst.de>
- Date
- 2021-07-16 06:32:57
- Also in
- linux-arm-kernel, linux-iommu, linux-mips, linux-s390, linuxppc-dev, lkml, sparclinux, xen-devel
- Reply to
- Logan Gunthorpe, 2021-07-15
On Thu, Jul 15, 2021 at 10:45:42AM -0600, Logan Gunthorpe wrote:
quoted hunk ↗ jump to hunk
@@ -458,7 +460,7 @@ static int gart_map_sg(struct device *dev, struct scatterlist *sg, int nents, iommu_full(dev, pages << PAGE_SHIFT, dir); for_each_sg(sg, s, nents, i) s->dma_address = DMA_MAPPING_ERROR; - return 0; + return ret;
While we're at it - setting the ->dma_address to DMA_MAPPING_ERROR is
not part of the ->map_sg calling convention. Might be worth to fix
up while we're at it.