On Tue, Sep 28, 2021 at 11:34 AM Petri Latvala [off-list ref] wrote:

On Tue, Sep 28, 2021 at 11:23:47AM -0400, Mark Yacoub wrote:

quoted

On Tue, Sep 28, 2021 at 11:20 AM Petri Latvala [off-list ref] wrote:

quoted

On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:

quoted

On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
[off-list ref] wrote:

quoted

Hi,

I also tested it using vkms and vc4.

I already applied the V1 in the upstream.

Thanks
Siqueira

On 09/28, Aurabindo Pillai wrote:

quoted

On 9/28/21 9:53 AM, Petri Latvala wrote:

quoted

On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:

quoted

On 9/28/21 5:15 AM, Petri Latvala wrote:

quoted

On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:

quoted

Skipping using the continue statement has the side effect of this
subtest being absent from the list of subtests, when running the
test executable with paramter --list-subtest. Is that okay ?

It's not okay btw. When you're not in an igt_fixture or an
igt_subtest, you cannot use anything that touches the hardware or the
running system in any way.

Hi Petri, can you elaborate more on this. I'm curious to understand
what you mean. I'm slightly confused.

All subtests must be enumerable regardless of hardware, basically.

In other words, you cannot do

igt_fixture {
  variable_assigned_in_fixture = value;
}

if (variable_assigned_in_fixture)
  igt_subtest("only-exists-sometimes") {}

Gotcha. thanks!
so can i still do
igt_subtest("my-subtest") {
  if (variable_assigned_in_fixture)
    run_subtest();
}

Yup.

Or if you want to be fancy, even

igt_subtest_with_dynamic("my-subtest") {
 if (variable_assigned_in_fixture)
   igt_dynamic("stuff")

very cool. ty!

     run_test();
}


--
Petri Latvala