Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
From: Mark Yacoub <hidden>
Date: 2021-09-27 17:21:41
On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai [off-list ref] wrote:
quoted hunk ↗ jump to hunk
[Why] The rationale of the test does not hold true for AMD hardware. The aperture size calculation has an upper bound check which is done through i915 specific IOCTL. Hence this part of subtest must be moved out of the platform agnostic tests. Moreover, AMD hardware supports buffers larger than aperture size. [How] Skip the bo-too-big subtest unless its run on i915 as the test fails on AMD, VKMS and VC4 Signed-off-by: Aurabindo Pillai <redacted> --- tests/kms_flip.c | 1 + 1 file changed, 1 insertion(+)diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 54137871..20112de1 100755 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c@@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs, /* 256 MB is usually the maximum mappable aperture, * (make it 4x times that to ensure failure) */ if (o->flags & TEST_BO_TOOBIG) {
There is also another place where TEST_BO_TOOBIG is used, should we skip this one as well or it's only this part?
+ igt_skip_on(!is_i915_device(drm_fd));
bo_size = 4*gem_mappable_aperture_size(drm_fd);
igt_require(bo_size < gem_global_aperture_size(drm_fd));
}
--
2.30.2