On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
[off-list ref] wrote:

Hi,

I also tested it using vkms and vc4.

I already applied the V1 in the upstream.

Thanks
Siqueira

On 09/28, Aurabindo Pillai wrote:

quoted

On 9/28/21 9:53 AM, Petri Latvala wrote:

quoted

On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:

quoted

On 9/28/21 5:15 AM, Petri Latvala wrote:

quoted

On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:

quoted

Skipping using the continue statement has the side effect of this
subtest being absent from the list of subtests, when running the
test executable with paramter --list-subtest. Is that okay ?

It's not okay btw. When you're not in an igt_fixture or an
igt_subtest, you cannot use anything that touches the hardware or the
running system in any way.

Hi Petri, can you elaborate more on this. I'm curious to understand
what you mean. I'm slightly confused.

quoted

quoted

quoted

quoted

In that case, please discard v2. Is this version good enough ?

No objections with v1.
Acked-by: Petri Latvala <redacted>

Thank you.

--
Rodrigo Siqueira
https://siqueira.tech