Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

Jeff King [off-list ref] writes:

On Sun, Sep 13, 2026 at 09:32:37AM -0700, Junio C Hamano wrote:

quoted

quoted

I think that since advice.* was originally assumed to be disabled
globally (as Jeff mentions, he expected it to be set in the user
config), adding "--global" to the hint is a good solution.  It makes
the hint actually cut-and-paste ready while still matching the
original intent.

The original intent was more like "the users are intelligent enough
to be able to decide which scope they want to use", I think.  I
agree that even with "--global" they can still cut-and-paste and
tweak if they wanted to, so I am OK with that move, but my point was
it probably is not even needed to mark each ones for which scope
they are suggested to be set (iow, we can just change the message to
always say "--global" without changing anything else).

Yeah, I was hinting that I think suggesting --global for all advice
would be fine. It's possible some particular advice would be better set
within a repo, but I kind of doubt it. And if we do find one, I think it
would be the exception, and then we could introduce a hint flag for that
one bit of advice in the other direction. :)

Yup, I love the simplicity of that approach.