Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

Junio C Hamano [off-list ref] writes:

It is very much understandable if we didn't mean the "use 'git
config advice.foo false' to disable" as a cut-and-paste ready
instruction, and rather meant as a general instruction that any
intelligent users would tweak for their own situation.  And it is
not surprising, from such a stance, the 'git config' hint would not
come with any scope indicator.

I think that since advice.* was originally assumed to be disabled
globally (as Jeff mentions, he expected it to be set in the user
config), adding "--global" to the hint is a good solution.  It makes
the hint actually cut-and-paste ready while still matching the
original intent.

As for "--system", "--worktree" and the like, I don't think it makes
sense to support them until there is a proven need.  I propose to
choose between local and global via a boolean flag, and treat all the
other scopes as YAGNI for now.

Thanks.