Re: [PATCH v4 2/3] advice: introduce advice scoping mechanism

Vsevolod Myalitsin [off-list ref] writes:

Junio C Hamano [off-list ref] writes:

quoted

It is very much understandable if we didn't mean the "use 'git
config advice.foo false' to disable" as a cut-and-paste ready
instruction, and rather meant as a general instruction that any
intelligent users would tweak for their own situation.  And it is
not surprising, from such a stance, the 'git config' hint would not
come with any scope indicator.

I think that since advice.* was originally assumed to be disabled
globally (as Jeff mentions, he expected it to be set in the user
config), adding "--global" to the hint is a good solution.  It makes
the hint actually cut-and-paste ready while still matching the
original intent.

The original intent was more like "the users are intelligent enough
to be able to decide which scope they want to use", I think.  I
agree that even with "--global" they can still cut-and-paste and
tweak if they wanted to, so I am OK with that move, but my point was
it probably is not even needed to mark each ones for which scope
they are suggested to be set (iow, we can just change the message to
always say "--global" without changing anything else).

Thanks.