Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects
From: Patrick Steinhardt <hidden>
Date: 2025-10-30 09:52:18
From: Patrick Steinhardt <hidden>
Date: 2025-10-30 09:52:18
On Thu, Oct 30, 2025 at 10:31:17AM +0100, Toon Claes wrote:
Patrick Steinhardt [off-list ref] writes:quoted
+ /* + * We have already checked `last_found`, so there is no need to + * re-check here. + */ + if (p == last_found && last_found != (void *)1) + continue;Unrelated to the (void *)1 check, shouldn't this be in the beginning of the loop?
Oh, good catch. Yes, it of course should be, thanks! Patrick