Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects
From: Toon Claes <hidden>
Date: 2025-10-30 09:31:27
From: Toon Claes <hidden>
Date: 2025-10-30 09:31:27
Patrick Steinhardt [off-list ref] writes:
+ /* + * We have already checked `last_found`, so there is no need to + * re-check here. + */ + if (p == last_found && last_found != (void *)1) + continue;
Unrelated to the (void *)1 check, shouldn't this be in the beginning of the loop? -- Cheers, Toon