Thread (79 messages) 79 messages, 4 authors, 2024-12-20

Re: [PATCH v4 0/8] refs: add reflog support to `git refs migrate`

From: karthik nayak <hidden>
Date: 2024-12-17 09:35:12

Patrick Steinhardt [off-list ref] writes:
On Mon, Dec 16, 2024 at 05:44:25PM +0100, Karthik Nayak wrote:
quoted
Changes in v4:
- Fix broken tests, due to two reasons in patch 8/8:
  - The `index` field in `reflog_migration_data` wasn't initialized to
    0. This specifically doesn't break the test, but causes undefined
    behavior. Fix this by using designated initializers.
  - The strbuf within `migration_data` wasn't initialized when the flow
    exited early, causing memory leaks. Fix this too by using designated
    initializers.
- Thanks to Junio for reporting and Patrick for helping shed some light
  on these broken tests.
- Link to v3: https://lore.kernel.org/r/20241215-320-git-refs-migrate-reflogs-v3-0-4127fe707b98@gmail.com (local)
The range-diff looks as expected, so this version of the series looks
good to me. Thanks!

Patrick
Thanks Patrick for your review!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help