Re: [PATCH v4 0/8] refs: add reflog support to `git refs migrate`
From: Patrick Steinhardt <hidden>
Date: 2024-12-17 07:00:09
From: Patrick Steinhardt <hidden>
Date: 2024-12-17 07:00:09
On Mon, Dec 16, 2024 at 05:44:25PM +0100, Karthik Nayak wrote:
Changes in v4:
- Fix broken tests, due to two reasons in patch 8/8:
- The `index` field in `reflog_migration_data` wasn't initialized to
0. This specifically doesn't break the test, but causes undefined
behavior. Fix this by using designated initializers.
- The strbuf within `migration_data` wasn't initialized when the flow
exited early, causing memory leaks. Fix this too by using designated
initializers.
- Thanks to Junio for reporting and Patrick for helping shed some light
on these broken tests.
- Link to v3: https://lore.kernel.org/r/20241215-320-git-refs-migrate-reflogs-v3-0-4127fe707b98@gmail.com (local)The range-diff looks as expected, so this version of the series looks good to me. Thanks! Patrick