Thread (64 messages) 64 messages, 7 authors, 2024-11-27

RE: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

From: Richard Kerry <hidden>
Date: 2024-11-20 14:31:36

quoted
The `read_refs_snapshot` uses the `parse_oid_hex` function which 
internally uses global variables. Let's instead use
Nit: s/variables/variable
No, that's fine.
It's plural, so ends with 's'.
Unless it should be "uses a global variable"
quoted
Also, while here, fix a missing newline after the functions definition.
Nit: s/functions/function
Maybe.
But it could be "the function's definition" as it could be seen as possessive.

Regards,
Richard.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help