Thread (64 messages) 64 messages, 7 authors, 2024-11-27

Re: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

From: shejialuo <hidden>
Date: 2024-11-20 12:58:35

On Tue, Nov 19, 2024 at 04:36:42PM +0100, Karthik Nayak wrote:
The `read_refs_snapshot` uses the `parse_oid_hex` function which
internally uses global variables. Let's instead use
Nit: s/variables/variable
`parse_oid_hex_algop` and provide the hash algo via `revs->repo`.

Also, while here, fix a missing newline after the functions definition.
Nit: s/functions/function
Signed-off-by: Karthik Nayak <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help