Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count()... | git

[PATCH 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
[PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
[PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
[PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
[PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
[PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · <hidden> · 2024-10-07
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Kristoffer Haugsbakk <hidden> · 2024-10-06
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Kristoffer Haugsbakk <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
[PATCH v4 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v4 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
[PATCH v5 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v5 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v5 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v5 2/2] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v5 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v6 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v6 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v6 2/2] t3404: employing test_line_count() to replace test · Phillip Wood <hidden> · 2024-10-07
Re: [PATCH v6 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v7 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v7 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v7 2/2] t3404: replace test with test_line_count() · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07

Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test

From: Eric Sunshine <hidden>
Date: 2024-10-07 04:38:22

On Sun, Oct 6, 2024 at 12:06 PM Usman Akinyemi via GitGitGadget
[off-list ref] wrote:

quoted hunk ↗ jump to hunk

Refactor t3404 to replace instances of `test` with `test_line_count()`
for checking line counts. This improves readability and aligns with Git's
current test practices.

Signed-off-by: Usman Akinyemi <redacted>
---

diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh

@@ -281,7 +281,8 @@ test_expect_success 'stop on conflicting pick' '
-       test 4 = $(grep -v "^#" < .git/rebase-merge/done | wc -l) &&
+       grep -v "^#" < .git/rebase-merge/done > actual &&
+       test_line_count = 4 actual &&

Thanks. Both patches in this series look fine.

Let's consider this a successfully-completed microproject.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help