Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes

[PATCH 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
[PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 1/2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
[PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH 2/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
[PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · shejialuo <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
[PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
[PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · <hidden> · 2024-10-07
Re: [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-06
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Kristoffer Haugsbakk <hidden> · 2024-10-06
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Eric Sunshine <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Kristoffer Haugsbakk <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-06
Re: [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
[PATCH v4 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v4 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
[PATCH v5 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v5 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v5 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v5 2/2] t3404: employing test_line_count() to replace test · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v5 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v6 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v6 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
Re: [PATCH v6 2/2] t3404: employing test_line_count() to replace test · Phillip Wood <hidden> · 2024-10-07
Re: [PATCH v6 2/2] t3404: employing test_line_count() to replace test · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Patrick Steinhardt <hidden> · 2024-10-07
Re: [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi <hidden> · 2024-10-07
[PATCH v7 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v7 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07
[PATCH v7 2/2] t3404: replace test with test_line_count() · Usman Akinyemi via GitGitGadget <hidden> · 2024-10-07

From: shejialuo <hidden>
Date: 2024-10-06 11:12:44

On Sun, Oct 06, 2024 at 05:19:13AM -0400, Eric Sunshine wrote:

[snip]

It probably would have been helpful to reviewers if the patch's
commit message mentioned that it only converts some of the
instances, but it's not worth rerolling the patch just for that.

Except that, the commit title should not either include
"[Outreachy][Patch v1]" here. From these two reasons, I think we should
reroll the patch.

Thanks,
Jialuo

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help