Re: [PATCH v2 02/10] ref-filter.h: add max_count and omit_empty to ref_format
From: Øystein Walle <hidden>
Date: 2023-11-16 12:06:46
Victoria Dye [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/ref-filter.h b/ref-filter.h index 1524bc463a5..d87d61238b7 100644 --- a/ref-filter.h +++ b/ref-filter.h@@ -92,6 +92,11 @@ struct ref_format { /* List of bases for ahead-behind counts. */ struct string_list bases; + + struct { + int max_count; + int omit_empty; + } array_opts; };
What the benefit of having them in a nested struct is compared to just two distinct members? Regardless this is the kind of deduplication I wanted to achieve when I added --omit-empty, but never did. Either way, I meant to ack this in the last round never got around to it. Nice work. Acked-by: Øystein Walle <redacted> Øsse