Thread (35 messages) 35 messages, 5 authors, 2023-11-16

Re: [PATCH 2/9] for-each-ref: clarify interaction of --omit-empty & --count

From: Øystein Walle <hidden>
Date: 2023-11-07 19:23:56

Hi Victoria,

Victoria Dye [off-list ref] writes:
Update the 'for-each-ref' builtin documentation to clarify that refs
"omitted" by --omit-empty are still counted toward the limit specified
by --count. The use of the term "omit" would otherwise be somewhat
ambiguous and could incorrectly be construed as excluding empty refs
entirely (i.e. not counting them towards the total ref count).
I implemented --omit-empty and I completely overlooked --count!

(If I were to do it all over again I probably would have implemented it
so that so-called omitted refs did not count towards the total. It makes
sense to me since e.g.  `git log -3 -- git.c` prints the three most
recent commits that touch git.c regardless of how many commits were
walked in the process.)

This is a good and welcome clarification. 

Acked-by: Øystein Walle <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help