Thread (50 messages) 50 messages, 7 authors, 2022-11-22

Re: [PATCH 00/18] make test "linting" more comprehensive

From: Jeff King <hidden>
Date: 2022-09-13 00:04:33

On Mon, Sep 12, 2022 at 07:17:12PM -0400, Eric Sunshine wrote:
quoted
I think we can live with it as-is for now and see how people react. If
lots of people are getting confused by the output, then that motivates
finding a solution. If not, then it's probably not worth the time.
Well, you nerd-sniped me anyhow. The result is at [1]. Following the
It seems we've discovered my true talent. :)
example of t/test-lib.sh, it uses `tput` if available to avoid
hardcoding color codes, and `tput` is invoked lazily, only if it
detects problems in the tests, so a normal (non-problematic) run
doesn't incur the overhead of shelling out to `tput`.
Ah, of course. I didn't think about the fact that the regular tests
already had to deal with this problem. Following that lead makes perfect
sense.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help