Re: [PATCH v4 00/33] submodule--helper: add tests, rm dead code, refactor & leak prep
From: Glen Choo <hidden>
Date: 2022-09-01 21:00:38
From: Glen Choo <hidden>
Date: 2022-09-01 21:00:38
Ævar Arnfjörð Bjarmason [off-list ref] writes:
This series is a "prep" series for the meaty leak fixes for submodule--helper, see [1] (which will be re-rolled on top of this v3). The v7 re-roll will be at [2]. Changes since v3: * Addressed (hopefully) all of the small feedback, just typo fixes & commit message clarifications. * Marked a parameter as "const", which helps reason about subsequent things in the "leak" series. Hopefully this is ready to proceed past "seen" in its current form... 1. https://lore.kernel.org/git/cover-v3-00.32-00000000000-20220821T130231Z-avarab@gmail.com/ (local) 2. https://lore.kernel.org/git/cover-v7-00.17-00000000000-20220831T231003Z-avarab@gmail.com (local)
Thanks! I still have no comments on the attributes and macros on 30/33. Others may want to take look at that. I spotted one typo in 31/33's commit message, but maybe that can be fixed on patch application. Otherwise, everything else LGTM. Reviewed-by: Glen Choo [off-list ref]