Re: [PATCH 08/20] submodule--helper: move "resolve-relative-url-test" to a test-tool
From: Glen Choo <hidden>
Date: 2022-07-29 21:58:27
Ævar Arnfjörð Bjarmason [off-list ref] writes:
As its name suggests the "resolve-relative-url-test" has never been used outside of the test suite, see 63e95beb085 (submodule: port resolve_relative_url from shell to C, 2016-04-15) for its original addition.
[...]
quoted hunk ↗ jump to hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> ---diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh index 1f2007e62b7..68e29c904a6 100755 --- a/t/t0060-path-utils.sh +++ b/t/t0060-path-utils.sh@@ -22,7 +22,7 @@ relative_path() { test_submodule_relative_url() { test_expect_success "test_submodule_relative_url: $1 $2 $3 => $4" " - actual=\$(git submodule--helper resolve-relative-url-test '$1' '$2' '$3') && + actual=\$(test-tool submodule resolve-relative-url '$1' '$2' '$3') && test \"\$actual\" = '$4' " }
It seems like this was only ever intended as a regression test when porting resolve_relative_url from sh -> C. Unless we see a good reason to "unit test" resolve_relative_url, I'm ok to drop this test too.
-- 2.37.1.1167.g38fda70d8c4