Thread (194 messages) 194 messages, 11 authors, 2022-04-07

Re: [PATCH v2 1/1] ls-tree.c: support `--oid-only` option for "git-ls-tree"

From: Teng Long <hidden>
Date: 2021-11-22 07:47:11

On Fri, 19 Nov 2021 14:30:52 +0100, Ævar Arnfjörð Bjarmason wrote
Please don't add the Reviewed-by headers yourself, either Junio
accumulates them, or if someone explicitly mentions that you can add it
with their name it's OK.
I think I misunderstood the meanings of the header before.
Thanks for the important tips.
Better: "Cannot be combined with OPT."
Better: "Cannot be combined with OPT or OPT2."
...
Better to preserve the wrapping here, to stay within 79 columns.
Will apply.
Just use:

    test_commit A &&
    test_commit B

etc?
...
Stray echo? Unclear why this test setup is so complex, shouldn't this just be (continued from above):

    mkdir -p C &&
    test_commit C/D.txt
To test nested dirs?
Will apply.

just cut -f1 instead of awk? Also don't put "git" on the LHS of a pipe,
it might hide segfaults. Also applies to the below.
Will apply, and could you please describe the problem with more details?
(appreciate if there is an executable example)

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help