on Mon, 15 Nov 2021 22:54:00 +0700, Đoàn Trần Công Danh wrote:

Thanks for helping to review this patch.

Failed with:

        GIT_TEST_DEFAULT_HASH=sha256 ./t3104-ls-tree-oid.sh

You totally right and the tests should pass both sha1 and sha256.

I think we can use:

        git ls-tree $tree | awk '{print $3}' >expected
...
...

Ditto for this test and below tests.

Yes, correct and better.

But should also escape the dollar character to work.

The last redirection '>/dev/null' does nothing, me think.
Style nit:

use '>expected' instead of '> expected'

Yeah, that's my bad and will fix.