Re: [PATCH 0/3] support `--oid-only` in `ls-tree`
From: Teng Long <hidden>
Date: 2021-11-19 02:58:07
A quick patch to do it below, seems to work, passes all tests, but I don't know how much I'd trust it. It's also quite an add use of strbuf_expa(). We print to stdout directly since write_name_quoted_relative() really wants to write to stdout, and not give you a buffer. But I guess it makes sense in a way.
Thanks for the patch and the inputs about "strbuf_expa()".
Then we'd be future-proof with the same interface expanding later, and wouldn't need to support options that we're only carrying because we didn't implement the more generic format support.
I agree but like Peff said it maybe another bigger task. I think I will firstly solve the existing problems in next patch. I will consider about the generic format support but not sure whether it will continue to iterate in this patchset.
(Assume my Signed-off-by, if there's any interest...)
Of course I will. Thank you very much for your advice and guidance again.