Thread (14 messages) flat view 14 messages, 5 authors, 2021-10-01

ab/config-based-hooks-1

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-10-01 15:11:42

On Thu, Sep 30 2021, Junio C Hamano wrote:
* ab/config-based-hooks-1 (2021-09-27) 8 commits
 - hook-list.h: add a generated list of hooks, like config-list.h
 - hook.c users: use "hook_exists()" instead of "find_hook()"
 - hook.c: add a hook_exists() wrapper and use it in bugreport.c
 - hook.[ch]: move find_hook() from run-command.c to hook.c
 - Makefile: remove an out-of-date comment
 - Makefile: don't perform "mv $@+ $@" dance for $(GENERATED_H)
 - Makefile: stop hardcoding {command,config}-list.h
 - Makefile: mark "check" target as .PHONY

 Mostly preliminary clean-up in the hook API.
I think this has gotten some thorough review from René & Phillip at this
point[1][2]. I think th consensus on the v2 is to just keep the "sed"
invocation I have as-is.

As you know the greater configurable hook topic is pending on this
moving forward, so starting to get at least some of it merged down
before 2.34 would be great. I was hoping we'd have a release with at
least the simpler hooks running via the new hook library (and perhaps
the --stdin cases too).

1. https://lore.kernel.org/git/0e07cee4-079a-af12-880f-d4a99300df28@web.de/ (local)
2. https://lore.kernel.org/git/6e7d5945-d64f-9511-9668-b453c20c086c@gmail.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help