Re: [PATCH v2 8/8] hook-list.h: add a generated list of hooks, like config-list.h

Am 27.09.21 um 18:48 schrieb Junio C Hamano:

Ævar Arnfjörð Bjarmason  [off-list ref] writes:

quoted

+sed -n \
+	-e '/^~~~~*$/ {x; s/^.*$/	"&",/; p;}' \
+	-e 'x' \
+	<Documentation/githooks.txt |
+	LC_ALL=C sort

Thanks.  It is not wrong per-se, but if you are willing to do a
multi-line script for readability, wouldn't a much more readable
"single long and multi-line string" approach, i.e.

    sed -ne '
	/^~~~~*$/ {
		x
		s/^.*$/ "&",/
		p
	}
	x
    ' Documentation/githooks.txt |
    LC_ALL=C sort

work better?

It is more readable, but according to OpenBSD's sed(1) manpage it would
also be non-portable (https://man.openbsd.org/sed#STANDARDS).  That note
was added in 2006 (https://github.com/openbsd/src/commit/24ce9718),
though, so perhaps it needs an update.

FWIW, generate-cmdlist.sh uses such a multi-line sed script in its
function get_synopsis.

René