Re: [PATCH v2 0/5] packfile: use oidset for bad objects

On Sat, Sep 11, 2021 at 10:31:52PM +0200, René Scharfe wrote:

Replace the custom hash array for remembering corrupt pack entries with
an oidset.  This shortens and simplifies the code.

Changes since v1:
- inline oidset_size()
- inline nth_midxed_pack_entry() early
- use oidset_size() to avoid a function call if no bad objects exist

Thanks, these all look fine to me. I raised a question elsewhere in the
thread about inlining oidset_contains(), but I think that can be
considered separately (and is less clear-cut; we might win by saving a
function call, but we might lose due to larger code size).

-Peff