Re: [PATCH 4/9] pack-write.c: rename `.idx` files after `*.rev`
flat view
From: Taylor Blau <hidden>
Date: 2021-09-09 14:46:37
On Thu, Sep 09, 2021 at 09:46:57AM +0200, Ævar Arnfjörð Bjarmason wrote:
On Wed, Sep 08 2021, Taylor Blau wrote:quoted
[...] Signed-off-by: Taylor Blau <redacted> Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> Signed-off-by: Taylor Blau <redacted>git commit --amend --signed-off-by-harder ? :)
I don't think so, though I had to check myself before sending.
Documentation/SubmittingPatches says:
Notice that you can place your own `Signed-off-by` trailer when
forwarding somebody else's patch with the above rules for
D-C-O. Indeed you are encouraged to do so. Do not forget to
place an in-body "From: " line at the beginning to properly attribute
the change to its true author (see (2) above).
Here it's awkward because you modified my original patch and then I sent
your modified result out. But I think the s-o-b chain still makes sense:
I wrote the original patch, and signed it off. Then you modified it,
signing that off. Finally, I sent it to the list, signing off on your
modification.
I.e. the duplicate header entry can go, maybe something Junio will fix up while queuing...
If I misread SubmittingPatches then I'm happy to fix it myself, but this was the intended outcome. Thanks, Taylor