Thread (66 messages) 66 messages, 3 authors, 2021-09-09

Re: [PATCH 0/2] pack-write,repack: prevent opening packs too early

From: Jeff King <hidden>
Date: 2021-09-01 06:08:51

On Wed, Sep 01, 2021 at 01:12:41AM -0400, Taylor Blau wrote:
On Wed, Sep 01, 2021 at 12:59:23AM -0400, Jeff King wrote:
quoted
So anyway. I think we definitely want the index-pack.c change. We
_could_ stop there and change the read side as a separate series, but I
think that until we do, the ordering changes on the write side aren't
really doing that much. They're shrinking the race a little, I guess,
but it's still very much there.
Yeah, now that I've had a chance to look at it it seems pretty
straightforward. Probably limited to checks in prepare_pack(), and
add_pack_to_midx(), which are the lone two callbacks of
for_each_file_in_pack_dir().
Yes, that matches what I'd expect.
I'll make sure that I'm not missing anything and then send a reroll
tomorrow.
Great, thanks!

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help