Thread (247 messages) flat view 247 messages, 9 authors, 2021-12-11

Re: [PATCH 12/15] scalar: teach 'reconfigure' to optionally handle all registered enlistments

From: Johannes Schindelin <hidden>
Date: 2021-09-08 18:21:21

Hi Eric,

On Fri, 3 Sep 2021, Eric Sunshine wrote:
On Fri, Sep 3, 2021 at 11:23 AM Johannes Schindelin
[off-list ref] wrote:
quoted
On Tue, 31 Aug 2021, Eric Sunshine wrote:
quoted
On Mon, Aug 30, 2021 at 5:35 PM Johannes Schindelin via GitGitGadget
quoted
+With the `--all` option, all enlistments currently registered with Scalar
+will be reconfigured. This option is meant to to be run every time Scalar
+was upgraded.
s/was/is/
I wanted to convey a temporal order, so I changed it to "every time after
Scalar is upgraded". Okay?
I think I understood the intent of the original, but it causes a
grammatical hiccup. Your revised version can work, although I might
write it this way:

    This option is meant to be run each time Scalar is upgraded.

However, perhaps that is too ambiguous and some users may think that
the process of upgrading Scalar will automatically run this command,
and you'd like to make it clear that it is the user's responsibility.
So, perhaps:

    Use this option after each Scalar upgrade.

or something.
I like the last one best, too.

Thank you,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help