Re: [PATCH 04/15] scalar: 'register' sets recommended config and starts maintenance
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-08-31 08:15:23
On Mon, Aug 30 2021, Derrick Stolee via GitGitGadget wrote:
[...]
+#ifndef WIN32
+ { "core.untrackedCache", "true" },
+#else
+ /*
+ * Unfortunately, Scalar's Functional Tests demonstrated
+ * that the untracked cache feature is unreliable on Windows
+ * (which is a bummer because that platform would benefit the
+ * most from it). For some reason, freshly created files seem
+ * not to update the directory's `lastModified` time
+ * immediately, but the untracked cache would need to rely on
+ * that.
+ *
+ * Therefore, with a sad heart, we disable this very useful
+ * feature on Windows.
+ */
+ { "core.untrackedCache", "false" },
+#endif
[...]Ok, but why the need to set it to "false" explicitly? Does it need to be so opinionated as to overwrite existing user-set config in these cases?
+ { "core.bare", "false" },Shouldn't this be set by "git init" already?
[...]
+ { "core.logAllRefUpdates", "true" },An opinionated thing unrelated to performance?
[...]
+ { "feature.manyFiles", "false" },
+ { "feature.experimental", "false" },Ditto the question about the need to set this, these are false by default, right?
[...]
+ if (git_config_get_string(config[i].key, &value)) {
+ trace2_data_string("scalar", the_repository, config[i].key, "created");
+ if (git_config_set_gently(config[i].key,
+ config[i].value) < 0)
+ return error(_("could not configure %s=%s"),
+ config[i].key, config[i].value);
+ } else {
+ trace2_data_string("scalar", the_repository, config[i].key, "exists");
+ free(value);
+ }The commit message doesn't discuss these trace2 additions, these in particular seem like they might be useful, but better done as as some more general trace2 intergration in config.c, i.e. if the functions being called here did the same logging on config set/get.