Thread (247 messages) flat view 247 messages, 9 authors, 2021-12-11

Re: [PATCH 10/15] scalar: implement the `run` command

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-08-31 08:29:03

On Mon, Aug 30 2021, Derrick Stolee via GitGitGadget wrote:
+	const char *usagestr[] = { NULL, NULL };
Missing usage strings?
+	if (argc == 0)
Style nit (per style guide): s/argc == 0/!argc/g.
+	if (!strcmp("all", argv[0]))
+		i = -1;
Style nit (per style guide): missing braces here.

(Just noting the style nits once, but more in this patch, and presumably
the rest of the series...)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help