Thread (164 messages) flat view 164 messages, 7 authors, 2021-09-18

Re: [PATCH] pack-write: skip *.rev work when not writing *.rev

From: Taylor Blau <hidden>
Date: 2021-09-08 03:50:24

On Tue, Sep 07, 2021 at 10:50:58PM -0400, Taylor Blau wrote:
Of the two, I think the former is more appealing (since no other
functions called by finish_tmp_packfile() are guarded like that; they
conditionally behave as noops depending on `flags`).
Sorry; this is nonsensical. The only other function we call is
write_idx_file() which merely changes its behavior based on flags, but
it never behaves as a noop.

That doesn't change my thinking about preferring the former of my two
suggestions, but just wanted to correct my error.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help