Thread (164 messages) flat view 164 messages, 7 authors, 2021-09-18

Re: [PATCH 4/5] commit-graph: refactor dispatch loop for style

From: Taylor Blau <hidden>
Date: 2021-02-15 18:54:18

On Mon, Feb 15, 2021 at 07:41:17PM +0100, Ævar Arnfjörð Bjarmason wrote:
I think it's more readable to have one if/elsif/else chain here than
the code this replaces.
FWIW, I find the pre-image more readable than what you are proposing
replacing it with here.

Of course, I have no doubts about the obvious correctness of this patch;
I'm merely suggesting that I wouldn't be sad to see us apply the first
three patches, and the fifth patch, but drop this one.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help