Thread (63 messages) flat view 63 messages, 6 authors, 2022-07-21
STALE1506d

[PATCH v3 02/11] remote: warn about unhandled branch.<name>.rebase values

From: Johannes Schindelin via GitGitGadget <hidden>
Date: 2021-09-07 21:05:22
Subsystem: the rest · Maintainer: Linus Torvalds

From: Johannes Schindelin <redacted>

We ignore them silently, but it actually makes sense to warn the users
that their config setting has no effect.

Signed-off-by: Johannes Schindelin <redacted>
---
 builtin/remote.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/builtin/remote.c b/builtin/remote.c
index 7f88e6ce9de..5705e088e5b 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -318,6 +318,9 @@ static int config_read_branches(const char *key, const char *value, void *cb)
 		 * truth value with >= REBASE_TRUE.
 		 */
 		info->rebase = rebase_parse_value(value);
+		if (info->rebase == REBASE_INVALID)
+			warning(_("unhandled branch.%s.rebase=%s; assuming "
+				  "'true'"), name, value);
 		break;
 	case PUSH_REMOTE:
 		if (info->push_remote_name)
-- 
gitgitgadget
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help