Thread (63 messages) flat view 63 messages, 6 authors, 2022-07-21

Re: [PATCH v2 5/7] rebase: drop support for `--preserve-merges`

From: Johannes Schindelin <hidden>
Date: 2021-09-02 13:54:34

Hi Ævar,

On Wed, 1 Sep 2021, Ævar Arnfjörð Bjarmason wrote:
On Wed, Sep 01 2021, Johannes Schindelin via GitGitGadget wrote:
quoted
-	struct strbuf script_snippet = STRBUF_INIT, buf = STRBUF_INIT;
+	struct strbuf script_snippet = STRBUF_INIT;
You end up removing all uses of script_snippet except the
strbuf_release() for it, so this & that can be removed too.
Valid point, I missed it because compiling with `DEVELOPER=1` did not
complain (because `strbuf_release()` "uses" the variable).

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help