Re: [PATCH v4 0/5] First steps towards partial clone submodules
From: Elijah Newren <hidden>
Date: 2021-06-19 20:01:18
From: Elijah Newren <hidden>
Date: 2021-06-19 20:01:18
On Thu, Jun 17, 2021 at 10:13 AM Jonathan Tan [off-list ref] wrote:
Quoting from [1]:quoted
I'm happy with Jonathan and Peff's responses on patch 3; as I mentioned above I just didn't understand the original code before Jonathan's changes. (Perhaps some comments could be added to clarify that code area, but again that's clarifying the code that existed before Jonathan's patch so it doesn't need to be part of his series.) So that only leaves my nitpicks on patches 1 & 4; otherwise the series looks good to me.I've addressed Elijah's comments on patches 1 and 4.
Yep, patches 1, 2, 4, and 5 are Reviewed-by me. While I looked over Patch 3, I made Peff explain it to me, so he's the one who reviewed that one. ;-)