Thread (59 messages) 59 messages, 5 authors, 2021-06-19

Re: [PATCH v2 4/4] promisor-remote: teach lazy-fetch in any repo

From: Jonathan Tan <hidden>
Date: 2021-06-09 04:46:09

On Mon, Jun 7, 2021 at 5:26 PM Jonathan Tan [off-list ref] wrote:
quoted
This is one step towards supporting partial clone submodules.

Even after this patch, we will still lack partial clone submodules
support, primarily because a lot of Git code that accesses submodule
objects does so by adding their object stores as alternates, meaning
that any lazy fetches that would occur in the submodule would be done
based on the config of the superproject, not of the submodule. This also
prevents testing of the functionality in this patch by user-facing
commands. So for now, test this mechanism using a test helper.
I wonder if this commit message is a good place to call out that we
also want to eventually audit codepaths using the old
has_promisor_remote() wrapper function (particularly the ones
protected by a repo == the_repository check) as well.
Sounds good. I think we will need to check uses of all wrappers.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help