Re: [PATCH 04/11] push: simplify setup_push_simple()
From: Felipe Contreras <hidden>
Date: 2021-05-28 21:28:58
From: Felipe Contreras <hidden>
Date: 2021-05-28 21:28:58
Elijah Newren wrote:
On Fri, May 28, 2021 at 1:10 PM Felipe Contreras [off-list ref] wrote:quoted
branch->refname can never be different from branch->merge[0]->src.This statement isn't true without additional qualifications. Perhaps extend your commit message with "...since the 'Additional safety' check dies if they differ." or some other wording that qualifies why it's true at the point of the code in question.
Will do. That in fact was in the back of my mind. -- Felipe Contreras