Thread (24 messages) 24 messages, 3 authors, 2021-05-29
STALE1830d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH 08/11] push: fix Yoda condition

From: Felipe Contreras <hidden>
Date: 2021-05-28 20:10:41
Subsystem: the rest · Maintainer: Linus Torvalds

We want to check if remote is the same as the branch remote, not the
other way around.

Signed-off-by: Felipe Contreras <redacted>
---
 builtin/push.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/push.c b/builtin/push.c
index f008cd624f..2dda1724cc 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -237,7 +237,7 @@ static void setup_push_simple(struct remote *remote, struct branch *branch, int
 
 static int is_workflow_triangular(struct remote *remote)
 {
-	return remote_get(NULL) != remote;
+	return remote != remote_get(NULL);
 }
 
 static void setup_default_push_refspecs(struct remote *remote)
-- 
2.32.0.rc0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help