[PATCH 07/11] push: remove redundant check
From: Felipe Contreras <hidden>
Date: 2021-05-28 20:10:37
Subsystem:
the rest · Maintainer:
Linus Torvalds
If fetch_remote is NULL (i.e. the branch remote is invalid), then it can't possibly be same as remote, which can't be NULL. The check is redundant, and so is the extra variable. Signed-off-by: Felipe Contreras <redacted> --- builtin/push.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/builtin/push.c b/builtin/push.c
index 2d6358f776..f008cd624f 100644
--- a/builtin/push.c
+++ b/builtin/push.c@@ -237,8 +237,7 @@ static void setup_push_simple(struct remote *remote, struct branch *branch, int static int is_workflow_triangular(struct remote *remote) { - struct remote *fetch_remote = remote_get(NULL); - return (fetch_remote && fetch_remote != remote); + return remote_get(NULL) != remote; } static void setup_default_push_refspecs(struct remote *remote)
--
2.32.0.rc0