On Thu, May 27, 2021 at 11:59:24AM -0500, Felipe Contreras wrote:
Jeff King wrote:
quoted
On Tue, May 25, 2021 at 02:51:54AM +0900, Junio C Hamano wrote:
quoted
quoted
Documentation/Makefile | 77 ++++++++++++++++--------------------------
1 file changed, 29 insertions(+), 48 deletions(-)
Is this satisfactory to everybody (I haven't taken a look beyond
comparing the end results)?
Yes, all five patches look good to me.
So... Acked-by?
If you want. I have never found that trailer to be particularly helpful.
quoted
The "comments-by" sub-thread looked unproductive to me, so I mostly
skipped it. ;) But as the person whose name was in the trailer, I will
say that I do not care either way if it is included. It did not seem to
add anything to me. Some trailers are good for pointing later readers to
folks who may be able to help understand or debug an old commit. Some
are good for just giving credit to people who helped. "Comments-by"
didn't really seem to do either to me (and I don't feel like I
contributed much worthy of credit anyway).
But you did provide comments, and those comments resulted in changes, so
the comments-by line is accurate. And for what it's worth that commit
trailer line has been used 3 times already, which places it in the 3rd
top decile.
I didn't say it was inaccurate. I just think it is not useful.
-Peff