Thread (14 messages) 14 messages, 3 authors, 2021-05-27

Re: [PATCH v3 3/5] doc: remove unnecessary rm instances

flat view

From: Felipe Contreras <hidden>
Date: 2021-05-24 18:45:37

Felipe Contreras wrote:
Junio C Hamano wrote:
quoted
Felipe Contreras [off-list ref] writes:
quoted
quoted
Comments-by: Jeff King [off-list ref]
This is curious.  I understand what other kinds of trailers like
Helped-by and Suggested-by people sometimes use mean, but this one
does not tell anything other than that this person had some comments
on an earlier rounds, does not tell us what kind of comments they
were and if something was done to address those comments or the
comments were totally ignored or what.
If they were ignored they would not be part of the commit. It is
understood the comments were incorporated.
Oh, and there are some instances already in the history:

7a9b0b802e (git-clean: add colors to interactive git-clean, 2013-06-25)
1b8fd46732 (git-clean: show items of del_list in columns, 2013-06-25)
52fd972d59 (git-completion: fix regression in zsh support, 2011-05-10)

Although one of those is mine.

Cheers.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help