Thread (14 messages) 14 messages, 3 authors, 2021-05-27

Re: [PATCH v3 0/5] doc: asciidoc cleanups

flat view

From: Jeff King <hidden>
Date: 2021-05-27 14:32:31

On Tue, May 25, 2021 at 02:51:54AM +0900, Junio C Hamano wrote:
quoted
 Documentation/Makefile | 77 ++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 48 deletions(-)
Is this satisfactory to everybody (I haven't taken a look beyond
comparing the end results)?
Yes, all five patches look good to me.

The "comments-by" sub-thread looked unproductive to me, so I mostly
skipped it. ;) But as the person whose name was in the trailer, I will
say that I do not care either way if it is included. It did not seem to
add anything to me. Some trailers are good for pointing later readers to
folks who may be able to help understand or debug an old commit. Some
are good for just giving credit to people who helped. "Comments-by"
didn't really seem to do either to me (and I don't feel like I
contributed much worthy of credit anyway).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help