Thread (139 messages) 139 messages, 5 authors, 2021-04-30

Re: [PATCH v2 04/30] subtree: t7900: use consistent formatting

From: Luke Shumaker <hidden>
Date: 2021-04-26 19:57:53

On Mon, 26 Apr 2021 11:44:59 -0600,
Luke Shumaker wrote:
quoted hunk ↗ jump to hunk
@@ -50,15 +46,17 @@ undo()
 # The original set of commits changed only one file each.
 # A multi-file change would imply that we pruned commits
 # too aggressively.
-join_commits()
-{
+join_commits () {
 	commit=
 	all=
 	while read x y; do
-		if [ -z "$x" ]; then
+		if test -z "$x"
+		then
 			continue
-		elif [ "$x" = "commit:" ]; then
-			if [ -n "$commit" ]; then
+		elif test "$x" = "commit:"
+		then
+			if test -n "$commit"
+			then
 				echo "$commit $all"
 				all=
 			fi
Whoops, I should have changed those 1-line `while ...; do`'s, in
addition to the 1-line `if ...; then`'s.

-- 
Happy hacking,
~ Luke Shumaker
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help